test: ensure assertions are reached on more tests #60763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60763 +/- ##
==========================================
- Coverage 88.57% 88.55% -0.02%
==========================================
Files 703 703
Lines 208259 208259
Branches 40178 40178
==========================================
- Hits 184458 184425 -33
- Misses 15824 15855 +31
- Partials 7977 7979 +2 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Nov 18, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
benjamingr
approved these changes
Nov 18, 2025
Collaborator
PR-URL: nodejs#60763 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95
force-pushed
the
must-call-mustCalls-r
branch
from
1cd3ddf to
fc203b3
Compare
Contributor
Author
|
Landed in fc203b3 |
targos
pushed a commit
that referenced
this pull request
Nov 27, 2025
PR-URL: #60763 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another followup of #60125 (should be the penultimate one)